Re: next-200110804 ARM build break (cpuidle_call_idle)

[Stephen Rothwell]

Hi Stephen,

On Thu, 4 Aug 2011 13:35:59 -0700 Stephen Warren <swarren@xxxxxxxxxx> wrote:
>
> With next-20110804, I'm seeing the following on ARM:
> 
> arch/arm/kernel/process.c: In function 'cpu_idle':
> arch/arm/kernel/process.c:200: error: implicit declaration of function 'cpuidle_call_idle'
> 
> This was previously fixed with:
> 
> https://lkml.org/lkml/2011/4/4/109
> 
> Commit 5f8cf82 (cpuidle: stop using pm_idle) converted arches to use
> cpuidle_idle_call() but contained typos on ARM and SH transposing the
> function name into cpuidle_call_idle().
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> 
> (which I think was included directly in linux-next according to that
> email thread)

Yeah, briefly by the looks of things.

> However, commit 5f8cf82 isn't in linux-next any more, but instead,
> a0bfa13 "cpuidle: stop depending on pm_idle" has replaced it, and has
> the same issue.

It was included first on April 4 and removed after I apllied tha bove fix
on April 15.  From April 18 on, it was not in the tree at all.  I don't
know why it has come back :-(

> Applying Mark's previous fix solves the build problem.

Hi Len.  This patch was wrong the first time around ...
-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature