Re: [PATCH] block: Make rq_affinity = 1 work as expected.

[Shaohua Li]

2011/8/5 Tao Ma <tm@xxxxxx>:
> From: Tao Ma <boyu.mt@xxxxxxxxxx>
>
> Commit 5757a6d76c introduced a new rq_affinity = 2 so as to make
> the request completed in the __make_request cpu. But it makes the
> old rq_affinity = 1 not work any more. The root cause is that
> if the 'cpu' and 'req->cpu' is in the same group and cpu != req->cpu,
> ccpu will be the same as group_cpu, so the completion will be
> excuted in the 'cpu' not 'group_cpu'.
>
> This patch fix problem by simpling removing group_cpu and the codes
> are more explicit now. If ccpu == cpu, we complete in cpu, otherwise
> we raise_blk_irq to ccpu.
good catch. This changed old behavior and can cause more lock contention.
and if user doesn't care about lock contention, he can use rq_affinity = 2

Reviewed-by: Shaohua Li <shaohua.li@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/