Re: [PATCH 5/8] staging: vme: add functions for bridge module refcounting

[Martyn Welch]

On 05/08/11 10:04, Manohar Vanga wrote:
> Hey Martin,
> 
>> Actually, it would give you a good indication of how many of the resources
>> provided by each VME bridge chip were used. I don't see the refcount
>> accurately reflecting the number of users as being important, more as a means
>> of tracking which bridges have resources that are being used (and therefore
>> can't be removed).
> 
> On second thought, I think I agree with Emilio that the _module_ refcount should
> reflect the number of users (other modules) using the bridge module. The refcount
> of resources should probably stay separate from the refcount of module usage. We
> can add resource refcounting as well but I don't see a need for it at the moment.
> 
> vme_bridge_get() and vme_bridge_put() in this case should refer to the reference
> count of the bridge module (not the resources). What do you think?
> 

I think that by refcounting the resources being used we will know whether a
bridge module is being used or not, thus whether it can be unloaded or not. By
reference counting the use of resources we minimise the chance of poorly
written drivers using resources, but not registering the fact that they are in
fact using a VME bridge.

Martyn

-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)127322748                          | Barbirolli Square, Manchester,
E martyn.welch@xxxxxx                      | M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/