Re: [PATCH] x86, olpc: Wait for last byte of EC command to beaccepted

[Ingo Molnar]

* Daniel Drake <dsd@xxxxxxxxxx> wrote:

> From: Paul Fox <pgf@xxxxxxxxxx>
> 
> When executing EC commands, only waiting when there are still more bytes to
> write is usually fine. However, if the system suspends very quickly after
> a call to olpc_ec_cmd(), the last data byte may not yet be transferred to
> the EC, and the command will not complete.
> 
> This solves a bug where the SCI wakeup mask was not correctly written
> when going into suspend.

What did that result in - a resume hang? (i.e. how urgent is this fix 
- v3.1 material or v3.2 material?)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/