Re: [PATCH] regulator: tps6586x: add SMx slew rate setting

[Mark Brown]

On Fri, Aug 05, 2011 at 07:51:15PM +0800, Danny Huang wrote:
> Thanks for the feedback.
> The reason for using driver_data is that I can't find a proper field in regulator_init_data for the slew rate setting.
> I'll do some correction based on the feedback and try to add a new field for the slew rate setting.

No, this is OK - we should really rename the driver_data field, it's
very misleading.  However:

> +       return tps6586x_write(parent, reg, setting->slew_rate);

what happens if the user sets zero for the slew rate (eg, if another
field is added to the platform data that they want to set)?  Is this a
sane setting (like the chip default) or might it break something?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/