Re: [PATCH] regulator: tps6586x: add SMx slew rate setting

From: Mark Brown
Date: Mon Aug 08 2011 - 09:33:07 EST


On Mon, Aug 08, 2011 at 08:28:30PM +0800, Danny Huang wrote:

> Zero is a valid setting for the regulator but not the default setting.
> The default setting is 0x07.
> This might affect the system stability under some particular condition.
> I thought that users should pick a proper setting before init.

It'd be good to do something like make the variable wider than the
register then require that users set an out of band bit to program the
value to zero. This would improve robustness in hte case where someone
relies on a zero initialized platform data by default.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/