Re: [Stable-review] [28/55] [SCSI] fix crash in scsi_dispatch_cmd()

From: Greg KH
Date: Mon Aug 08 2011 - 13:05:42 EST


On Sun, Aug 07, 2011 at 06:51:24PM +0100, Ben Hutchings wrote:
> On Sun, 2011-08-07 at 18:50 +0100, Ben Hutchings wrote:
> > On Fri, 2011-08-05 at 17:01 -0700, Greg KH wrote:
> > > 2.6.32-longterm review patch. If anyone has any objections, please let us know.
> > >
> > > ------------------
> > >
> > > From: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> > >
> > > commit bfe159a51203c15d23cb3158fffdc25ec4b4dda1 upstream.
> > >
> > > USB surprise removal of sr is triggering an oops in
> > > scsi_dispatch_command(). What seems to be happening is that USB is
> > > hanging on to a queue reference until the last close of the upper
> > > device, so the crash is caused by surprise remove of a mounted CD
> > > followed by attempted unmount.
> > [...]
> >
> > This has been reported in 2.6.39.y and 3.0, but not in 2.6.32.y.
>
> That is, AFAIK.

Oops, good catch, I've dropped this from the .32 and .33 queue now, it's
not needed there at all.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/