Re: [PATCH] GPIOLIB: add generic gpio_set_pull API

From: Grant Likely
Date: Mon Aug 08 2011 - 14:25:17 EST

On Mon, Aug 8, 2011 at 2:15 AM, Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
> On Sun, Aug 07, 2011 at 10:19:33PM -0700, Barry Song wrote:
>> Now there are many different implementations for GPIO pull configuration, for
>> example:
>> s3c_gpio_setpull()
>> tegra_pinmux_set_pullupdown()
>> chipcHw_setPinPullup()
>> gpio_pullup()
>> s3c2410_gpio_pullup()
>> This patch adds a new generic gpio_set_pull API so that all SoCs can have unified
>> codes.
>> Signed-off-by: Barry Song <Baohua.Song@xxxxxxx>
> For arch/arm/mach-shmobile we also have gpio_pull_up() for board-g4evm.c
> and gpio_pull_down() for board-mackerel.c. Both of these would benefit
> from this sort of an API addition.

I think I'm okay with this API change. Linus, what say you? How does
this interact with your plans for pinctrl?


Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at