Re: [PATCH] nbd: some trivial improvements

From: Cong Wang
Date: Tue Aug 09 2011 - 03:16:35 EST

ä 2011å08æ09æ 01:20, Greg KH åé:
On Mon, Aug 08, 2011 at 05:00:04PM +0800, Amerigo Wang wrote:
This patch 1) uses task_pid_nr(current) to get the pid of current process,
2) replaces sysfs_create_file() with device_create_file(), 3) lower
the loglevel of an error message.

As you are doing 3 different things, please make this 3 different
patches (remember, one patch per logical thing being done.)

Since you insist, will do.

if (max_part< 0) {
- printk(KERN_CRIT "nbd: max_part must be>= 0\n");
+ printk(KERN_ERR "nbd: max_part must be>= 0\n");

Again, dev_err() please. That properly identifies exactly which device
had problems.

Ok, thanks for pointing this out!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at