Re: [RFC][PATCH 2/2] spi: s3c64xx: Use clkdev for bus clock lookup

From: Jassi Brar
Date: Tue Aug 09 2011 - 08:43:26 EST

On Tue, Aug 9, 2011 at 7:28 PM, Padmavathi Venna <padma.v@xxxxxxxxxxx> wrote:
> SPI driver is modified to lookup the bus clock using the
> alias name instead of getting clock name and clock
> number from platform data.

> Driver is modified to get the best source clock among the
> available source clocks for the required frequency.
I am not sure if this driver should be deciding which clock is 'best' for it.
Because ...
1) Usually it's the board designer who decides which clock to run at
what speed based upon target device. So ideally, based upon use-case
the driver should simply get the 'best' clock from board via platform in a
format that is compliant to the 'generic clock api'.
2) We are not changing source clock rates(and we should not).
So the 'best' clock found, might still be way off in accuracy. And when we
can't anyway guarantee accuracy, why not leave the decision to
the board designer who might, say, select the source clock good enough
to be useful to more than one controller yet not absolutely accurate for any ?
3) It keeps enabled 3 unused clocks all the time.

> diff --git a/drivers/spi/spi_s3c64xx.c b/drivers/spi/spi_s3c64xx.c
> index 8945e20..d7c979d 100644
> --- a/drivers/spi/spi_s3c64xx.c
> +++ b/drivers/spi/spi_s3c64xx.c
> @@ -132,6 +132,9 @@
> Â#define RXBUSY Â Â(1<<2)
> Â#define TXBUSY Â Â(1<<3)
> +#define MAX_SPI_BUS_CLK (4)
> +#define MAX_PSR (256)


#define MAX_SPI_BUS_CLK 4
#define MAX_PSR 256

is safe ... even safer than with two on!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at