Re: [PATCH] treewide: Update sha_transform
From: Linus Torvalds
Date: Tue Aug 09 2011 - 11:41:54 EST
On Tue, Aug 9, 2011 at 1:58 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> Eliminate possible sha_transform unaligned accesses to data by copying
> data to an aligned __u32 array if necessary.
This is wrong. Not only does it double the stack space, when I tried
it for git it just made things slower. So don't do it.
If some architecture has a bad "get_unaligned_be32()", then that's
just something for the arch maintainers to fix.
> Add sha_transform wipe argument to force workspace clearing if desired.
I disagree. As already mentioned, any competent compiler would make
that thing go away anyway. And there is no reason to believe that it's
actually a real fix for any real security issue, so it's voodoo
programming for several reasons.
We shouldn't do voodoo stuff. Or rather, I'm perfectly ok if you guys
all do your little wax figures of me in the privacy of your own homes
- freedom of religion and all that - but please don't do it in the
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/