Re: [patch 1/1] [PATCH] include storage keys in hibernation image.
From: Martin Schwidefsky
Date: Tue Aug 09 2011 - 11:45:56 EST
On Fri, 29 Jul 2011 00:01:14 +0200
"Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> Sorry for the extreme delay.
No big deal, I have been busy with other things anyway.
> Having reconsidered things I think the code under the #ifdef above
> should really go to arch/s390.
Ok, that is reasonable.
> Now, for the purpose of exporting the headers I'd introduce
> CONFIG_ARCH_SAVE_PAGE_KEYS and make S390 do
> select ARCH_SAVE_PAGE_KEYS if HIBERNATION
> and I'd put a #ifdef depending on that into include/linux/suspend.h.
> Apart from this, I have only one complaint, which is that the kerneldoc
> comments should follow the standard (the other comments in snapshot.c don't,
> but that's a matter for a separate patch).
Sounds good. I will come up with new patches for this and resend them
for review. Might be one or two weeks though, currently conferencing in
"Reality continues to ruin my life." - Calvin.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/