Tegra I2C driver compilation failure (was: RE: [PATCH] dt: addempty of_get_property for non-dt)

From: Stephen Warren
Date: Tue Aug 09 2011 - 12:21:59 EST

Stephen Warren wrote at Monday, August 08, 2011 1:26 PM:
> Rob Herring wrote at Sunday, August 07, 2011 8:38 AM:
> > On 08/05/2011 05:50 PM, Stephen Warren wrote:
> > > The patch adds empty function of_get_property for non-dt build, so that
> > > drivers migrating to dt can save some '#ifdef CONFIG_OF'.
> > >
> > > This also fixes the current Tegra compile problem in linux-next.
> >
> > You could just use of_property_read_u32 in the driver. It already has
> > empty version and will simplify the driver code some.
> Yes, that would also work.
> Grant, Ben, do you have a preference for which option to choose?

Well, all three possible fixes have been posted now:

Add ifdef to i2c driver:

Implement empty of_get_property:

Switch i2c driver to use of_property_read_u32:

Ben, please could you please pick one of the changes and apply it, so
that linux-next compiles for Tegra? Thanks!


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/