Re: [patch 1/2] fuse: delete dead .write_begin and .write_end aops
From: Christoph Hellwig
Date: Wed Aug 10 2011 - 06:26:18 EST
On Mon, Aug 08, 2011 at 05:05:20PM +0200, Miklos Szeredi wrote:
> > The loop code still calls them uncondtionally. This actually is a big
> > as write_begin and write_end require filesystems specific locking,
> > and might require code in the filesystem to e.g. update the ctime
> > properly. I'll let Miklos chime in if leaving them in was intentional,
> > and if it was a comment is probably justified.
> Loop checks for ->write_begin() and falls back to ->write if the former
> isn't defined.
> So I think the patch is fine. I tested loop over fuse, and it still
> works after the patch.
It works, but it involves another data copy, which will slow down
various workloads that people at least historically cared about.
And yes, unconditionally above was wrong - calls them if present without
taking care of filesystem specific locking would be the right term.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/