Re: [RFC][PATCH 1/2] S5PV210: SPI: Add clkdev support
From: Sylwester Nawrocki
Date: Wed Aug 10 2011 - 08:59:17 EST
On 08/10/2011 02:04 PM, padma venkat wrote:
> Hi Sylwester,
> On Tue, Aug 9, 2011 at 7:12 PM, Sylwester Nawrocki
> <s.nawrocki@xxxxxxxxxxx> wrote:
>> [corrected Jassi's email address]
>> On 08/09/2011 03:57 PM, Padmavathi Venna wrote:
>>> Create a clkdev alias for spi bus clock and modify the spi
>>> driver to lookup the clock using the alias name instead of
>>> passing clock name and clock number from SPI platform data.
>>> Signed-off-by: Padmavathi Venna <padma.v@xxxxxxxxxxx>
>>> This patch is tested for S5PV210 platform and similar
>>> changes can be adopted for rest of the Samsung's s3c
>>> and s5p platforms, if this approach is accepted.
>> It is a bit surprising to me how you do intend to use the clock aliases.
>> Are we seriously going to be creating clock con_id aliases for most
>> of the available devices ? It doesn't sound sane to me..
> We don't need to create the alias names for all the devices. But we need
> to create only for those which need clock information from platform data.
> As far as I know we need to create for spi,hsmmc,uart and iis.
That's already a lot.
Just to clarify, the clock names were originally passed in platform_data
because they differ across SoCs the driver supports, right ?
Or are there any other reasons ?
The whole idea of the clkdev is not to require any information about
the clocks in platform_data. You just need to be registering the clock
identifiers *at the device*, not the clock names specific to the machine.
The platform code takes care of the translation and the drivers only need
to ask clkdev for the 'clock connection id', rather than the original
machine clock name.
You can do this by adding the aliases, but it's not optimal. You are adding
the code which could well be avoided.
>> Wouldn't it be possible to avoid the aliases by correcting the clock
>> registration process ?
> Yes it is possible but we don't have the flexibility to create the alias names
> only for the required clocks.
By registering proper clock connection ids you would not need the aliases at all.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/