Re: [PATCH] mfd/ab8500-gpadc: refactor GPADC API, add raw access

[Linus Walleij]

On Mon, Jul 4, 2011 at 5:30 PM, Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote:
> On Tue, Jun 28, 2011 at 11:08:03AM +0200, Linus Walleij wrote:
>> From: Kalle Komierowski <kalle.komierowski@xxxxxxxxx>
>>
>> - A bug in the use of the exported functions made the raw ADC
>>   value converted to voltage entity twice.
>
> Please separate this one from the API renaming/clarification.

Sorry that line is just a clarification for the patch itself. The
signature of the functions made that bug occur in consumers
calling the GPADC functions, due to the fact that they
though massaged values were raw.

So by doing this API change the mistake is not that easy
to make again.

I'll reword and repost the patch.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/