[PATCH 4/8] drivers:misc: ti-st: fail-safe on wrong pkt type

From: pavan_savoy
Date: Wed Aug 10 2011 - 11:19:26 EST

From: Vijay Badawadagi <bvijay@xxxxxx>

Texas Instrument's shared transport driver interpret incoming data from the
UART based on the various protocol drivers registered to the driver such as
btwilink driver or FM or GPS driver which provide logical channel IDs.

In case of bad-behavior from chip such as HCI Event response for a GPS command
or a HCI Event (h/w error event) for a FM response & In case of bad-behavior
from UART driver such as dropping data bytes a fail-safe is required to avoid
kernel panic.

Signed-off-by: Pavan Savoy <pavan_savoy@xxxxxx>
Signed-off-by: Vijay Badawadagi <bvijay@xxxxxx>
drivers/misc/ti-st/st_core.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index c8e335d..1f973ce 100644
--- a/drivers/misc/ti-st/st_core.c
+++ b/drivers/misc/ti-st/st_core.c
@@ -338,6 +338,12 @@ void st_int_recv(void *disc_data,
/* Unknow packet? */
type = *ptr;
+ if (st_gdata->list[type] == NULL) {
+ pr_err("chip/interface misbehavior dropping"
+ " frame starting with 0x%02x", type);
+ goto done;
+ }
st_gdata->rx_skb = alloc_skb(
@@ -354,6 +360,7 @@ void st_int_recv(void *disc_data,
spin_unlock_irqrestore(&st_gdata->lock, flags);
pr_debug("done %s", __func__);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/