Re: [PATCH 4/5] writeback: per task dirty rate limit

[Vivek Goyal]

On Wed, Aug 10, 2011 at 11:29:54AM +0800, Wu Fengguang wrote:

[..]
> > > -	ratelimit = ratelimit_pages;
> > > -	if (mapping->backing_dev_info->dirty_exceeded)
> > > +	ratelimit = current->nr_dirtied_pause;
> > > +	if (bdi->dirty_exceeded)
> > >  		ratelimit = 8;
> > 
> > Should we make sure that ratelimit is more than 8? It could be that
> > ratelimit is 1 and we set it higher (just reverse of what we wanted?)
> 
> Good catch! I actually just fixed it in that direction :)
> 
>         if (bdi->dirty_exceeded)
> -               ratelimit = 8;
> +               ratelimit = min(ratelimit, 32 >> (PAGE_SHIFT - 10));

With page size 64K, will above lead to retelimit 0? Is that what you want.
I wouldn't think so.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/