Re: [PATCH 02/10] tracing/filter: Separate predicate init andfilter addition

From: Steven Rostedt
Date: Wed Aug 10 2011 - 16:51:45 EST

On Thu, 2011-08-04 at 12:08 +0200, Jiri Olsa wrote:
> Separating the filter_pred initialization from code
> that adds the filter_pred to the filter.
> The create_pred returns initialized predicate, which
> is added to the filter by filter_add_pred function.
> Keeping dry_run variable inside replace_preds function.

The only issue I have with this patch is the change log. It tells me
what you are doing, but does not tell us why you are doing it.

I'm pretty clueless about reviewing this patch, as I don't know what the
goal of the patch is. It's like a patch that says, increment i

+ i++;

-- Steve

> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at