Re: [PATCH 3/3] x86-64: Rework vsyscall emulation and add vsyscall= parameter

From: Andrew Lutomirski
Date: Wed Aug 10 2011 - 18:56:52 EST


On Wed, Aug 10, 2011 at 6:20 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> Andrew Lutomirski <luto@xxxxxxx> wrote:
>
>>On Wed, Aug 10, 2011 at 5:14 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>>>
>>> Please rebase your patch on the current -linus since it appears to
>>have changed since x86/vdso was merged.
>>>
>>
>>Can you double-check?  I think it's the other way around: x86/vdso has
>>fixes that should be pushed to Linus.
>>
>>$ git log tip/x86/vdso ^origin/master --oneline
>>c149a66 x86-64: Add vsyscall:emulate_vsyscall trace event
>>318f5a2 x86-64: Add user_64bit_mode paravirt op
>>5d5791a x86-64, xen: Enable the vvar mapping
>>f670bb7 x86-64: Work around gold bug 13023
>>9c40818 x86-64: Move the "user" vsyscall segment out of the data
>>segment.
>>1bdfac1 x86-64: Pad vDSO to a page boundary
>>17b0436 Merge commit 'v3.0' into x86/vdso
>>
>>--Andy
>
> You're right, although coupling it makes the testing harder.

If it helps, I can probably generate a new series that merges 9c40818
with the latest patch and makes the result independent of the rest
(except for the trace event). I'm not sure it's worth it, though.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/