Re: [PATCH 1/2][cleanup] memcg: renaming of mem variable to memcg
From: Michal Hocko
Date: Thu Aug 11 2011 - 05:03:35 EST
On Thu 11-08-11 14:27:06, Raghavendra K T wrote:
> On 08/11/2011 01:34 PM, Michal Hocko wrote:
> >On Wed 10-08-11 22:59:29, Raghavendra K T wrote:
> >>This patch renames all mem variables to memcg in source file.
> >__mem_cgroup_try_charge for example uses local mem which cannot be
> >renamed because it already has a memcg argument (mem_cgroup **) then we
> >have mem_cgroup_try_charge_swapin and mem_cgroup_prepare_migration which
> >use mem_cgroup **ptr (I guess we shouldn't have more of them).
> >I think that __mem_cgroup_try_charge should use ptr pattern as well.
> >Other than that I think the clean up is good.
> >With __mem_cgroup_try_charge:
> >Acked-by: Michal Hocko<mhocko@xxxxxxx>
> Agreed, Let me know whether you prefer whole patch to be posted or
> only the corresponding hunk.
I would go with the full (single) patch. I would also recommend to add
results of your tests into the changelog (which configurantion have been
tested and how did you test binary compatibility).
SUSE LINUX s.r.o.
190 00 Praha 9
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/