Re: [patch v5 7/8] crc32-add-slicing-by-8.diff

[Joakim Tjernlund]

Bob Pearson <rpearson@xxxxxxxxxxxxxxxxxxxxx> wrote on 2011/08/11 00:44:52:
>
> extend add slicing-by-8 algorithm to the existing
> slicing-by-4 algorithm. This consists of:
>
>    - extend largest BITS size from 32 to 64
>    - extend table from tab[4][256] to tab[8][256]
>    - change algorithm to align on 8 byte boundary
>      (it was noted that all that is really required
>      is that the inner loop must comsume 8 bytes.
>      As written it can start on even or odd 4 byte
>      boundary.)
>    - Add code for inner loop.
>
> Signed-off-by: Bob Pearson <rpearson@xxxxxxxxxxxxxxxxxxxxx>
>
> ---
>  lib/crc32.c          |   60 ++++++++++++++++++++++++++++++++++++++++++---------
>  lib/crc32defs.h      |   14 +++++------
>  lib/gen_crc32table.c |   40 ++++++++++++++++++++--------------

While looking at gen_crc32table.c I see that much of my remarks still stands

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/