Re: [PATCH v3 1/3] drivers/block/mtip32xx: Adding header file andsource for pci and block related operation
From: Christoph Hellwig
Date: Thu Aug 11 2011 - 18:46:45 EST
On Thu, Aug 11, 2011 at 12:52:43PM -0600, Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONTRACTOR] wrote:
> This is the first part of the new block driver,mtip32xx, for Micron
> PCIe SSD, which contains the header file and source for pci and
> block related operations.
There should be not split between pci/block and hardware related
functions, as there is no logical split either. Please remove that
layering and merge the files into one. Also given that the hardware
really just is AHCI with extensions please use the constants from
include/linux/ata.h and drivers/ata/ahci.h instead of redefining them.
The latter might need to be move to include/linux before merging the
driver for that, but for the next iteration a hacky relative include
might be enough.
Also please get rid of the MTIP_USE_TASKLET, if it really is worth it
it needs to be seletable at runtime.
I can't see any point of the CONFIG_PCI_MSI ifdefs - all the functions
called under it are properly stubbed out if it's not enabled.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/