Re: [PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge structby value

From: Stephen Rothwell
Date: Sat Aug 13 2011 - 04:06:14 EST

Hi all,

On Sat, 13 Aug 2011 01:04:36 +0200 (CEST) Jesper Juhl <jj@xxxxxxxxxxxxx> wrote:
> From: Jesper Juhl <jj@xxxxxxxxxxxxx>
> Date: Sat, 13 Aug 2011 00:51:40 +0200
> struct ieee80211_network is fairly large (more than half a kilobyte),
> so let's pass a pointer instead of passing the entire structure by
> value when ieee80211_is_54g() and ieee80211_is_shortslot() need to
> look at a few members.
> Also remove parentheses around the values being returned from those
> two functions - 'return' is not a function.

Also, is there some reason that they are not "static inline bool"
functions defined directlt in ieee80211.h?

Stephen Rothwell sfr@xxxxxxxxxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature