Re: [PATCH v2 2/2] crypto, x86: SSSE3 based SHA1 implementation for x86-64

From: Mathias Krause
Date: Sun Aug 14 2011 - 15:09:56 EST


On Thu, Aug 11, 2011 at 4:50 PM, Andy Lutomirski <luto@xxxxxxx> wrote:
> I have vague plans to clean up extended state handling and make
> kernel_fpu_begin work efficiently from any context.  (i.e. the first
> kernel_fpu_begin after a context switch could take up to ~60 ns on Sandy
> Bridge, but further calls to kernel_fpu_begin would be a single branch.)
>
> The current code that handles context switches when user code is using
> extended state is terrible and will almost certainly become faster in the
> near future.

Sounds good! This would not only improve the performance of sha1_ssse3
but of aesni as well.

> Hopefully I'll have patches for 3.2 or 3.3.
>
> IOW, please don't introduce another thing like the fpu crypto module quite
> yet unless there's a good reason.  I'm looking forward to deleting the fpu
> module entirely.

I've no intention to. So please go ahead and do so.


Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/