Re: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h
From: Shawn Guo
Date: Mon Aug 15 2011 - 02:06:47 EST
On 15 August 2011 13:46, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 15 Aug 2011 13:35:58 +0800 Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
>> On 15 August 2011 11:54, Chris Ball <cjb@xxxxxxxxxx> wrote:
>> > On Sun, Aug 14 2011, Shawn Guo wrote:
>> >> There are following warning and error when compiling the driver.
>> >> The patch adds the missing inclusion of linux/module.h to fix them.
>> >> drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has
>> >> no type or storage class
>> > Pushed to mmc-next for 3.1. I don't see these on my imx build with
>> > CONFIG_MMC_SDHCI_ESDHC_IMX=m, so it'd be useful to see your .config
>> > so that I'm able to reproduce in future.
>> I guess it's not about .config but sources. I spot this on
>> linux-next-20110812. Are you trying the same tree? I will test
>> v3.1-rc2 tag when I can actually fetch it. (Linus released it, but it
>> has not been available with 'git fetch' yet.)
> It could well be an interaction with the module.h split up, in which case
> it will only appear in linux-next. That said, I don;t get that error in
> my manual builds, so the config (or at least ARCH) could be useful.
My .config is attached. It's used to build i.mx53 image.
Before you start building it, you need to cherry-pick the following
commit from Linus' tree to fix another error.
Author: Arnaud Patard (Rtp) <arnaud.patard@xxxxxxxxxxx>
Date: Fri Aug 5 09:32:41 2011 +0200
iMX: Fix build for iMX53
Description: Binary data