Re: [PATCH 16/18] dmaengine/amba-pl08x: Add support for sg lengreater than one for slave transfers
From: Linus Walleij
Date: Mon Aug 15 2011 - 06:11:51 EST
On Sun, Aug 14, 2011 at 10:36 AM, Russell King - ARM Linux
> On Fri, Jul 29, 2011 at 04:19:26PM +0530, Viresh Kumar wrote:
>> Untill now, sg_len greater than one is not supported. This patch adds support to
>> do that.
> I'm not sure that this is the correct approach. memcpy()s can only be
> used with one single buffer, so the sg stuff for that (and the unmapping
> support) doesn't make sense at all.
I agree, that part is fishy.
> The only place where this makes sense is the slave sg stuff. I wonder
> whether we can better deal with that by having the LLI setup code deal
> with one SG list entry at a time, and chain each together.
> Something I've also been pondering which is related to this is linking
> together DMA operations using the LLI chaining when interrupts and
> callbacks aren't required. It's a very similar problem. Other DMA
> engine drivers do this.
Yeah. Viresh can you hold this patch off for the moment, move it to
the end of the series and see if we can find some more optimal
approach for this?
> Finally, note that some of the PL08x code assumes that for any TXD,
> the LLI list is a contiguous array. See the first part of
> pl08x_getbytes_chan(). That needs fixing as soon as we start going to
> more than one SG list entry.
Actually, after the removal of the phantom boundary in the PL08x
driver, the LLI handling code starts to resemble the stuff inside
the coh901318.c driver an *awful lot*, so I'm now ever more
convinced that that thing is a PL08x derivate. (I have asked the
hardware designers but the people who made it are unreachable.)
And the coh901318 code handles this by properly walking the LLIs
in memory IIRC, so could be a good inspiration.
I am aware that we need to consolidate that LLI handling so
the coh901318 and PL08x share the same LLI code atleast, or I
may even be able to merge all into pl08x.c. I have a mental note
to get to that once we've got PL08x into shape, until then it
can atleast be used for inspiration.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/