Re: [PATCH] hpsa: add heartbeat sysfs host attribute

From: scameron
Date: Mon Aug 15 2011 - 11:04:21 EST

On Mon, Aug 15, 2011 at 09:40:22AM -0500, scameron@xxxxxxxxxxxxxxxxxx wrote:
> On Fri, Aug 12, 2011 at 07:01:47PM -0700, Greg KH wrote:
> > On Fri, Aug 12, 2011 at 01:03:14PM -0500, Stephen M. Cameron wrote:
> > > From: Stephen M. Cameron <scameron@xxxxxxxxxxxxxxxxxx>
> > >
> > > The cciss driver had a CCISS_HEARTBEAT ioctl which
> [...]
> > >
> > > + The "heartbeat" read-only attribute returns the value of a heartbeat
> > > + counter register on a Smart Array controller as a 32 bit unsigned
> > > + hexadecimal integer (e.g: "0x12345678"). The value should change
> > > + periodically, not less than once per second. If this value fails to
> > > + change for a period longer than one second, it means something has
> > > + gone wrong (e.g. Smart Array controller firmware has locked up.)
> > > +
> >
> > This all belongs in Documentation/ABI/ care to move it there instead?
> Sure.

Now that I look, I'm not seeing where any of the generic scsi
host or device attributes are documented in Documenation/ABI.

It's not very clear to me where in Documentation/ABI I should
document a driver's custom scsi device and host attributes as
even the generic scsi device and host attributes seem to be

from scsi_sysfs.c, I see these, for example:


but I don't see them documented anywhere in Documentation/ABI,
and hpsa.c adds these custom sdev attrs:

static struct device_attribute *hpsa_sdev_attrs[] = {

Likewise, there are generic scsi host attrs in scsi_sysfs.c:

static struct attribute *scsi_sysfs_shost_attrs[] = {

Also undocumented.

hpsa.c adds custom host attrs:
static struct device_attribute *hpsa_shost_attrs[] = {

How should I proceed?

-- steve

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at