Re: [PATCH 14/14] [media] gspca: Use current logging styles

[Jean-Francois Moine]

On Sun, 21 Aug 2011 15:56:57 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> Add pr_fmt.
> Convert usb style logging macros to pr_<level>.
> Remove now unused old usb style logging macros.

Hi Joe,

Sorry, but I do not see the advantages of your patch.

For gspca, the source files are bigger, and the only visible change is
the display of the real module name instead of the name defined by hand
(this change may have been done just in gspca.h).

Also, I think that defining 'pr_fmt' in each source file is not a good
idea...

-- 
Ken ar c'hentaÃ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/