Re: [PATCH 2/4] debug-pagealloc: add support for highmem pages

[Akinobu Mita]

2011/8/23 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>:

> This seems more complicated than is needed.  Couldn't we just do
>
> static void poison_page(struct page *page)
> {
>        void *addr;
>
>        preempt_disable();
>        addr = kmap_atomic(page);
>        set_page_poison(page);
>        memset(addr, PAGE_POISON, PAGE_SIZE);
>        kunmap_atomic(addr);
>        preempt_enable();
> }
>
> ?

This code looks much better.  I'll update the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/