Re: [PATCH 2/4 v4] pinmux: add a driver for the U300 pinmux

[Barry Song]

Hi Linus,
This patch can't compile....
> +
> +/**
> + * @dev: a pointer back to containing device
> + * @virtbase: the offset to the controller in virtual memory
> + */
> +struct u300_pmx {
> + Â Â Â struct device *dev;
> + Â Â Â struct pinmux_dev *pmx;

no this structure in head file, now it is pinctrl_desc.

> + Â Â Â u32 phybase;
> + Â Â Â u32 physize;
> + Â Â Â void __iomem *virtbase;
> +};

> + Â Â Â /* Now register the pin controller and all pins it handles */
> + Â Â Â upmx->pctl = pinctrl_register(&u300_pmx_desc, &pdev->dev, upmx);

no this field in upmx structure.

> + Â Â Â if (IS_ERR(upmx->pctl)) {

Did you send the wrong version?

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/