Re: [PATCH 2/4 v4] pinmux: add a driver for the U300 pinmux

[Barry Song]

> +/**
> + * @dev: a pointer back to containing device
> + * @virtbase: the offset to the controller in virtual memory
> + */
> +struct u300_pmx {
> + Â Â Â struct device *dev;
> + Â Â Â struct pinmux_dev *pmx;

 pinctrl_dev?

> +static int u300_pmx_enable(struct pinmux_dev *pmxdev, unsigned selector)

 pinctrl_dev?

> +{
> + Â Â Â struct u300_pmx *upmx;
> +
> + Â Â Â if (selector >= ARRAY_SIZE(u300_pmx_funcs))
> + Â Â Â Â Â Â Â return -EINVAL;
> + Â Â Â upmx = pmxdev_get_drvdata(pmxdev);
> + Â Â Â u300_pmx_endisable(upmx, selector, true);
> +
> + Â Â Â return 0;
> +}
> +
> +static void u300_pmx_disable(struct pinmux_dev *pmxdev, unsigned selector)

 pinctrl_dev?

> +{
> + Â Â Â struct u300_pmx *upmx;
> +
> + Â Â Â if (selector >= ARRAY_SIZE(u300_pmx_funcs))
> + Â Â Â Â Â Â Â return;
> + Â Â Â upmx = pmxdev_get_drvdata(pmxdev);

pctrldev_get_drvdata?

> + Â Â Â u300_pmx_endisable(upmx, selector, false);
> +}
> +
> +static int u300_pmx_list(struct pinmux_dev *pmxdev, unsigned selector)

 pinctrl_dev?

> +{
> + Â Â Â if (selector >= ARRAY_SIZE(u300_pmx_funcs))
> + Â Â Â Â Â Â Â return -EINVAL;
> + Â Â Â return 0;
> +}
> +
> +static const char *u300_pmx_get_fname(struct pinmux_dev *pmxdev,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â unsigned selector)

 pinctrl_dev?

> +{
> + Â Â Â if (selector >= ARRAY_SIZE(u300_pmx_funcs))
> + Â Â Â Â Â Â Â return NULL;
> + Â Â Â return u300_pmx_funcs[selector].name;
> +}
> +
> +static int u300_pmx_get_pins(struct pinmux_dev *pmxdev, unsigned selector,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Âunsigned ** const pins, unsigned * const num_pins)

 pinctrl_dev?

> +{
> + Â Â Â if (selector >= ARRAY_SIZE(u300_pmx_funcs))
> + Â Â Â Â Â Â Â return -EINVAL;
> + Â Â Â *pins = (unsigned *) u300_pmx_funcs[selector].pins;
> + Â Â Â *num_pins = u300_pmx_funcs[selector].num_pins;
> + Â Â Â return 0;
> +}
> +
> +static void u300_dbg_show(struct pinmux_dev *pmxdev, struct seq_file *s,

 pinctrl_dev?

> + Â Â Â Â Â Â Â Â Âunsigned offset)
> +{
> + Â Â Â seq_printf(s, " " DRIVER_NAME);
> +}
> +
> +static struct pinmux_ops u300_pmx_ops = {
> + Â Â Â .list_functions = u300_pmx_list,
> + Â Â Â .get_function_name = u300_pmx_get_fname,
> + Â Â Â .get_function_pins = u300_pmx_get_pins,
> + Â Â Â .enable = u300_pmx_enable,
> + Â Â Â .disable = u300_pmx_disable,
> + Â Â Â .dbg_show = u300_dbg_show,
> +};
> +
> +static struct pinmux_desc u300_pmx_desc = {
> + Â Â Â .name = DRIVER_NAME,
> + Â Â Â .pins = u300_pads,
> + Â Â Â .npins = ARRAY_SIZE(u300_pads),
> + Â Â Â .maxpin = U300_NUM_PADS-1,
> + Â Â Â .pmxops = &u300_pmx_ops,
> + Â Â Â .owner = THIS_MODULE,
> +};
> +
> +static int __init u300_pmx_probe(struct platform_device *pdev)
> +{
> + Â Â Â int ret;
> + Â Â Â struct u300_pmx *upmx;
> + Â Â Â struct resource *res;
> +
> + Â Â Â /* Create state holders etc for this driver */
> + Â Â Â upmx = kzalloc(sizeof(struct u300_pmx), GFP_KERNEL);
> + Â Â Â if (!upmx)
> + Â Â Â Â Â Â Â return -ENOMEM;
> +
> + Â Â Â upmx->dev = &pdev->dev;
> +
> + Â Â Â res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + Â Â Â if (!res) {
> + Â Â Â Â Â Â Â ret = -ENOENT;
> + Â Â Â Â Â Â Â goto out_no_resource;
> + Â Â Â }
> + Â Â Â upmx->phybase = res->start;
> + Â Â Â upmx->physize = resource_size(res);
> +
> + Â Â Â if (request_mem_region(upmx->phybase, upmx->physize,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â ÂDRIVER_NAME) == NULL) {
> + Â Â Â Â Â Â Â ret = -EBUSY;
> + Â Â Â Â Â Â Â goto out_no_memregion;
> + Â Â Â }
> +
> + Â Â Â upmx->virtbase = ioremap(upmx->phybase, upmx->physize);
> + Â Â Â if (!upmx->virtbase) {
> + Â Â Â Â Â Â Â ret = -ENOMEM;
> + Â Â Â Â Â Â Â goto out_no_remap;
> + Â Â Â }
> +
> + Â Â Â /* Now register the pin controller and all pins it handles */
> + Â Â Â upmx->pctl = pinctrl_register(&u300_pmx_desc, &pdev->dev, upmx);
> + Â Â Â if (IS_ERR(upmx->pctl)) {
> + Â Â Â Â Â Â Â dev_err(&pdev->dev, "could not register U300 pinmux driver\n");
> + Â Â Â Â Â Â Â ret = PTR_ERR(upmx->pmx);
> + Â Â Â Â Â Â Â goto out_no_pmx;
> + Â Â Â }
> + Â Â Â platform_set_drvdata(pdev, upmx);
> +
> + Â Â Â dev_info(&pdev->dev, "initialized U300 pinmux driver\n");
> +
> + Â Â Â return 0;
> +
> +out_no_pmx:
> + Â Â Â iounmap(upmx->virtbase);
> +out_no_remap:
> + Â Â Â platform_set_drvdata(pdev, NULL);

where have you set drv data to non-NULL?

> +out_no_memregion:
> + Â Â Â release_mem_region(upmx->phybase, upmx->physize);
> +out_no_resource:
> + Â Â Â kfree(upmx);
> + Â Â Â return ret;
> +}
> +

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/