Re: [PATCH v2 17/43] microblaze: Use set_current_blocked() and block_sigmask()

[Michal Simek]

Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@xxxxxxxxx>
>
> As described in e6fa16ab ("signal: sigprocmask() should do
> retarget_shared_pending()") the modification of current->blocked is
> incorrect as we need to check whether the signal we're about to block
> is pending in the shared queue.
>
> Also, use the new helper function block_sigmask() which centralises
> the code for updating current->blocked after successfully delivering a
> signal and reduces the amount of duplicate code across
> architectures. In the past some architectures got this code wrong, so
> using this helper function should stop that from happening again.
>
> Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> Cc: Michal Simek <monstr@xxxxxxxxx>
> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
> ---
>
> v2 of this patch depends on "[PATCH 01/43] signal: Add block_sigmask()
> for adding sigmask to current->blocked" so they need to go through the
> same tree but this patch would benefit from some maintainer ACK's.

Please add there my ACK to it too.

> Michal, I dropped your Acked-by because I felt this patch changed
> quite dramatically since v1 and warrants another review. I hope that's
> OK.

That's fine. I have run LTP tests and results look good.
I will add patches 14-16/43 v2 to microblaze next branch keep them
for a while. I will propose them to Linus tree for v3.2.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/