Re: [PATCHv4 1/4] usb: Provide usb_speed_string() function

[Felipe Balbi]

Hi,

On Mon, Aug 22, 2011 at 11:16:07PM +0200, Michal Nazarewicz wrote:
> >>>>+obj-$(CONFIG_USB)		+= common.o
> >>>>+obj-$(CONFIG_USB_GADGET)	+= common.o
> 
> >>>Will this cause problems?  For example, what if CONFIG_USB is Y and
> >>>CONFIG_USB_GADGET is M?
> 
> >>>Also, it seems a little silly to have an entire kernel module devoted
> >>>to a single, little function.
> 
> On Mon, 22 Aug 2011 23:06:43 +0200, Alan Stern
> <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> >You could do:
> >
> >	obj-$(CONFIG_USB_SUPPORT)  += common.o
> >
> >which would build that subroutine into the main kernel whenever either
> >side of the USB stack is enabled.
> 
> OK.  I'll wait for any more possible comments and post changed version
> by the end of the week.

if it's only for one single function, wouldn't a static inline in a
common header do ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature