Re: [RFC] fs, proc: Introduce the /proc/<pid>/map_files/ directory v2

From: Cyrill Gorcunov
Date: Wed Aug 24 2011 - 05:39:49 EST


On Wed, Aug 24, 2011 at 11:34:31AM +0200, Tejun Heo wrote:
> Hello,
>
> On Wed, Aug 24, 2011 at 12:53:29PM +0400, Cyrill Gorcunov wrote:
> > +static const struct dentry_operations tid_map_files_dentry_operations = {
> > + .d_revalidate = pid_revalidate,
> > + .d_delete = pid_delete_dentry,
> > +};
>
> Why pid_revalidate? Shouldn't it be verifying the entry against the
> current vmas? vmas (of course) can change while the process is
> running.
>
> Thanks.
>

Hmm, good point, letme check...

Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/