Re: [PATCH 03/18] x86/ticketlock: Use C for __ticket_spin_unlock

[Linus Torvalds]

On Wed, Aug 24, 2011 at 10:52 AM, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
>
> If we don't need to use a locked inc for unlock, then implement it in C.

Ok, so I really hate this patch.

What the f&*^ is the point of doing it this way? It just ends up being
incredibly ugly, with a mixture of C, asm, and barriers. The "C"
version is actually *uglier* than the non-C version, so why do it in C
at all?

Just get rid of this one.  It adds lines of code, makes the code
harder to read, and is just a disaster.

                        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/