Re: [PATCH 1/4] x86: base support for the TS-5500 platform

[Vivien Didelot]

On Wed, 24 Aug 2011 15:10:23 -0700,
"H. Peter Anvin" <hpa@xxxxxxxxx> wrote:

> On 08/24/2011 03:08 PM, Vivien Didelot wrote:
> > Indeed this will be run on any Elan SC520 based platforms if the
> > user has asked for TS-5500 support in the menuconfig. I could add
> > checks for other hardware such as the Ethernet controller, but it
> > would require including pci headers and delaying the initcall
> > (using late_initcall instead of postcore_initcall).
> > That's why I think it is not really worth adding more tests. They
> > could be added later in this function if there is really a need.
> > 
> > Regards,
> > Vivien.
> 
> Hello?  HELLO?
> 
> We do not break unrelated hardware just because something is enabled
> at compile time.
> 
> EVER.
> 
> 	-hpa

I agree with you. The platform does not provide many identification
points. We have specific hardware such as the CPU, Ethernet, Cardbus
and USB controllers; there is no DMI available; no PCI bridge subvendor
info, only the BIOS provides a 16-bit identification call...
We discussed that point in https://lkml.org/lkml/2011/5/4/437 without
success.

What would be the proper way in your opinion?

Vivien.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/