Re: [PATCH 5/6] cgroup, cpuset: don't use ss->pre_attach()

From: Tejun Heo
Date: Thu Aug 25 2011 - 05:06:34 EST


On Thu, Aug 25, 2011 at 01:53:57AM -0700, Paul Menage wrote:
> On Tue, Aug 23, 2011 at 3:19 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > ->pre_attach() is supposed to be called before migration, which is
> > observed during process migration but task migration does it the other
> > way around.  The only ->pre_attach() user is cpuset which can do the
> > same operaitons in ->can_attach().  Collapse cpuset_pre_attach() into
> > cpuset_can_attach().
> >
> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>
> Acked-by: Paul Menage <paul@xxxxxxxxxxxxxx>
>
> Code looks good, but I think that the some of the Documentation
> changes slipped in here by mistake.

Oops, indeed. Will relocate them.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/