Re: [RFC PATCH 1/3] MIPS: PCI: Use pci_bus_remove_resources()/pci_bus_add_resource()to set up root resources

From: Bjorn Helgaas
Date: Thu Aug 25 2011 - 11:35:15 EST


On Thu, Aug 25, 2011 at 12:41 AM, Deng-Cheng Zhu
<dengcheng.zhu@xxxxxxxxx> wrote:
> 2011/8/24 Bjorn Helgaas <bhelgaas@xxxxxxxxxx>:
>> Wouldn't it be enough to have [PATCH 2/3], which adds the
>> pci_create_bus() argument with nobody using it yet, then [PATCH 3/3],
>> which makes mips supply the new argument, and add a hunk to [PATCH
>> 3/3] that completely removes the bus->resource fixups in
>> pcibios_fixup_bus() at the same time?
>>
>> Bjorn
>>
>
> Do you mean to merge this patch to [PATCH 3/3]? OK, that's good!

No, I just mean that I don't see why you need this patch at all. If
you pass the list of bus resources to pci_create_bus(), there's no
need to fix anything up later. Or am I missing something?

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/