Re: RFC: Remove unnecessary / duplicate OOM printks

From: Andrew Morton
Date: Thu Aug 25 2011 - 18:05:07 EST


On Thu, 25 Aug 2011 13:47:23 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> There are many thousands of printks for OOM conditions
> in kernel sources.
>
> These are almost always a duplication of a generic
> OOM message from the mm subsystem.
>
> The biggest difference between the generic OOM and
> the specific OOM uses is that most of the specific
> messages are emitted at KERN_ERR but the generic
> message is at KERN_WARNING.
>
> Many KB of code/text could be removed from the kernel.
>
> Removal can be gradual and done by subsystem.
>
> Some kmalloc's that are followed on failure by vmalloc
> may need to add GFP_NOWARN.
>
> Does anyone really believe the per site failure
> messages are useful or really want them to keep them?
>

Kill 'em.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/