Re: [PATCH] Fix missing 'cnt' in ?: in dmatest

[Dan Williams]

On Sat, Aug 20, 2011 at 6:12 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Aug 21, 2011 at 01:50:31AM +0100, Dr. David Alan Gilbert wrote:
>
>> (WTH is x=y?:z legal C anyway?)
>
> gccism.  It's not legal C; it's a gcc extension, and not a pretty one at
> that.  It's almost definitely a bug in this case - what used to be in the
> tree is equivalent to cnt > 0 ? cnt > 0 : 0, i.e. cnt > 0 ? 1 : 0, i.e.
> cnt > 0.  AFAICS, after your patch it does make sense.
>
>> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Thanks, I'll take this through the async_tx.git tree.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/