Re: [PATCH 1/4] dynamic_debug: consolidate repetitive struct _ddebugdescriptor definitions

From: Bart Van Assche
Date: Fri Aug 26 2011 - 06:47:18 EST

On Thu, Aug 25, 2011 at 7:34 PM, Jason Baron <jbaron@xxxxxxxxxx> wrote:
>
> +#define DECLARE_DYNAMIC_DEBUG_METADATA(name, fmt)              \
> +       static struct _ddebug __used __aligned(8)               \
> +       __attribute__((section("__verbose"))) name = {          \
> +               .modname = KBUILD_MODNAME,                      \
> +               .function = __func__,                           \
> +               .filename = __FILE__,                           \
> +               .format = fmt,                                  \
> +               .lineno = __LINE__,                             \
> +               .flags =  _DPRINTK_FLAGS_DEFAULT,               \
> +               .enabled = false,                               \
> +       }

A minor remark: macro arguments are usually surrounded by parentheses
in a macro definition. That's not the case for "fmt" in the above.

Bart.
¢éì¹»®&Þ~º&¶¬?+-±éݶ¥?w®?Ë?±Êâméb?ìdz¹Þ?)í?æèw*jg¬±¨¶????Ý¢j/?êäz¹Þ??à2?Þ?¨è­Ú&¢)ß¡«a¶Úþø®G«?éh®æj:+v?¨?wè?Ù¥>W?±êÞiÛaxPjØm¶?ÿà -»+?ùd?_