Re: [PATCH] oom: skip frozen tasks

[Konstantin Khlebnikov]

Michal Hocko wrote:
> On Fri 26-08-11 14:03:17, Konstantin Khlebnikov wrote:
> > Michal Hocko wrote:
> >
> > > @@ -450,6 +459,10 @@ static int oom_kill_task(struct task_struct *p, struct mem_cgroup *mem)
> > >   			pr_err("Kill process %d (%s) sharing same memory\n",
> > >   				task_pid_nr(q), q->comm);
> > >   			task_unlock(q);
> > > +
> > > +			if (frozen(q))
> > > +				thaw_process(q);
> > > +
> >
> > We must thaw task strictly after sending SIGKILL.
>
> Sounds reasonable.
>
> > But anyway I think this is a bad idea.
>
> Why?

Refrigerator may be used for digging in task's internal structures,
so such digger may be very surprised if somebody suddenly thaws this task.

> > >   			force_sig(SIGKILL, q);
> > >   		}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/