[01/35] genirq: Fix wrong bit operation

From: Greg KH
Date: Sat Aug 27 2011 - 11:01:02 EST


3.0-stable review patch. If anyone has any objections, please let us know.

------------------

From: "jhbird.choi@xxxxxxxxxxx" <jhbird.choi@xxxxxxxxxxx>

commit 1dd75f91ae713049eb6baaa640078f3a6549e522 upstream.

(!msk & 0x01) should be !(msk & 0x01)

Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
Link: http://lkml.kernel.org/r/1311229754-6003-1-git-send-email-jhbird.choi@xxxxxxxxxxx
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
kernel/irq/generic-chip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/kernel/irq/generic-chip.c
+++ b/kernel/irq/generic-chip.c
@@ -246,7 +246,7 @@ void irq_setup_generic_chip(struct irq_c
gc->mask_cache = irq_reg_readl(gc->reg_base + ct->regs.mask);

for (i = gc->irq_base; msk; msk >>= 1, i++) {
- if (!msk & 0x01)
+ if (!(msk & 0x01))
continue;

if (flags & IRQ_GC_INIT_NESTED_LOCK)
@@ -301,7 +301,7 @@ void irq_remove_generic_chip(struct irq_
raw_spin_unlock(&gc_lock);

for (; msk; msk >>= 1, i++) {
- if (!msk & 0x01)
+ if (!(msk & 0x01))
continue;

/* Remove handler first. That will mask the irq line */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/