Re: [PATCH 06/14] [media] cx18: Use current logging styles

From: Jean-Francois Moine
Date: Sat Aug 27 2011 - 13:05:53 EST


On Sat, 27 Aug 2011 09:42:32 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> Andy, I fully understand how this stuff works.
> You apparently don't (yet).
>
> Look at include/linux/printk.h
>
> #ifndef pr_fmt
> #define pr_fmt(fmt) fmt
> #endif
>
> A default empty define is used when one
> is not specified before printk.h is
> included. kernel.h includes printk.h

Hi Joe,

Yes, but, what if pr_fmt is redefined in some driver specific include
by:

#undef pr_fmt
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

(in gspca.h for example) ?

--
Ken ar c'hentaà | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/