Re: m68k: [v5] Convert to genirq (WIP)

[Geert Uytterhoeven]

On Sun, Aug 28, 2011 at 04:08, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 26 Aug 2011, Geert Uytterhoeven wrote:
>> - [PATCH 18/24]: m68k/mac: Optimize interrupts using chain handlers (NEW)
>
> That patch has a mistake --
>
> Â Â Â Âirq_set_chained_handler(IRQ_AUTO_4, psc_irq);
> Â Â Â Âirq_set_handler_data(IRQ_AUTO_3, (void *)0x40);
> Â Â Â Âirq_set_chained_handler(IRQ_AUTO_5, psc_irq);
> Â Â Â Âirq_set_handler_data(IRQ_AUTO_3, (void *)0x50);
> Â Â Â Âirq_set_chained_handler(IRQ_AUTO_6, psc_irq);
> Â Â Â Âirq_set_handler_data(IRQ_AUTO_3, (void *)0x60);
>
> should be
>
> Â Â Â Âirq_set_chained_handler(IRQ_AUTO_4, psc_irq);
> Â Â Â Âirq_set_handler_data(IRQ_AUTO_4, (void *)0x40);
> Â Â Â Âirq_set_chained_handler(IRQ_AUTO_5, psc_irq);
> Â Â Â Âirq_set_handler_data(IRQ_AUTO_5, (void *)0x50);
> Â Â Â Âirq_set_chained_handler(IRQ_AUTO_6, psc_irq);
> Â Â Â Âirq_set_handler_data(IRQ_AUTO_6, (void *)0x60);

Woops, of course. Thanks!

> On one VIA-based machine that I tested, !CONFIG_USE_GENERIC_HARDIRQS
> gives:
>
> # cat /proc/interrupts
> auto    1:    2299 via1
> auto    2:    3876 via2
> auto    4:    Â562 SCC
> auto    7:     Â0 NMI
> mac    10:    Â590 pmu-shift
> mac    12:     90 pmu-clock
> mac    14:    1635 timer
> mac    17:    3876 nubus
> mac    56:    3879 sonic
>
> whereas, CONFIG_USE_GENERIC_HARDIRQS=y gives:
>
> # cat /proc/interrupts
> Â Â Â Â Â CPU0
> Â4: Â Â Â 5303 Â Â Âauto ÂSCC
> Â7: Â Â Â Â Â0 Â Â Âauto ÂNMI
> Â10: Â Â Â 2136 Â Â Â mac Âpmu-shift
> Â12: Â Â Â Â607 Â Â Â mac Âpmu-clock
> Â14: Â Â Â41858 Â Â Â mac Âtimer
> Â56: Â Â Â66876 Â Â Â mac Âsonic
> ERR: Â Â Â Â Â0
>
> Are there no counters for chained IRQs?

I noticed the same for Amiga.

> Other than these issues everything looks OK. I will test OSS and Baboon
> when I get the relevant hardware set up.

Thanks again!

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/