Re: [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c

From: Cong Wang
Date: Sun Aug 28 2011 - 22:30:31 EST


ä 2011å08æ26æ 04:57, David Rientjes åé:
On Thu, 25 Aug 2011, Cong Wang wrote:

No, it doesn't work, CONFIG_HUGETLBFS can be enabled with CONFIG_NUMA=y
and CONFIG_SYSFS=n and that uses data structures from drivers/base/node.c
which doesn't get compiled with this patch.

So, you mean with CONFIG_NUMA=y&& CONFIG_SYSFS=n&& CONFIG_HUGETLBFS=y
we still get compile error?

Which data structures are used by hugetlbfs?


node_states[], which is revealed at link time if you tried to compile your
patch. It's obvious that we don't want to add per-node hugetlbfs
attributes to sysfs directories if sysfs is disabled, so you need to
modify the hugetlbfs code as well.

Makes sense. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/