Re: [PATCH v4 00/18] Introduce a led trigger for CPU activity andconsolidate LED driver in ARM

[Bryan Wu]

On Mon, Aug 29, 2011 at 7:00 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Fri, Aug 26, 2011 at 11:03 AM, Bryan Wu <bryan.wu@xxxxxxxxxxxxx> wrote:
>
>> Based on Linus Walleij's ARM LED consolidation work, this patchset introduce a
>> new generic led trigger for CPU not only for ARM but also for others.
>
> I think Russell was pretty clear that he saw problems inside the "new LEDs"
> subsystem (drivers/leds) that need be fixed before we migrate this support
> to use the LED class devices.
>
> Can you see if you can address his comment on the earlier realview patch,
> i.e. this:
> http://marc.info/?l=linux-arm-kernel&m=131237280009775&w=2
>

Yeah, I replied that email with a patch to select LEDS_CLASS when
CONFIG_NEW_LEDS=y.

But you know, there is no comments about that.

> rpurdie: your comments on the state of the LEDs class?
>
> If I get time I will attempt to fix it, no clue when that will be though.
>

Thanks a lot, I think our ledtrig-cpu patches are quite good for
merging, although Russell has some concern about leds subsystem.

Regards,
-- 
Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/