Re: [PATCH v2] sound: usb: mixer: increase control transfer timeout

[Jassi Brar]

On Mon, Aug 29, 2011 at 7:35 PM, Clemens Ladisch <clemens@xxxxxxxxxx> wrote:

>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= val_len) {
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â buf, val_len, 1000) >= 0) {
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â !value, 0, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â value, index + 2, NULL, 0, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â jacks[i].unitid << 8, buf, 3, 1000);
>> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â 50, 0, &new_status, 1, 1000);
>>
>> How about also converting to use a local define for timeout value ?
>
> ... now that _all_ calls to snd_usb_ctl_msg use the same timeout value,
> we could just as well drop this parameter.
Sounds better, esp when we have 9 arguments to snd_usb_ctl_msg!
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i