Re: [Drbd-dev] [RFC 000/118] drbd: part 1 of adding multiple volume support to drbd

[Philipp Reisner]

Am Montag, 29. August 2011, 15:26:16 schrieb Greg Freemyer:
> On Mon, Aug 29, 2011 at 7:46 AM, Philipp Reisner
> 
> <philipp.reisner@xxxxxxxxxx> wrote:
> > Am Freitag, 26. August 2011, 15:20:51 schrieb Greg Freemyer:
> >> On Thu, Aug 25, 2011 at 11:06 AM, Philipp Reisner <
> >> 
> >> philipp.reisner@xxxxxxxxxx> wrote:
> >> > This the first request for review of drbd-8.4. The complete set has
> >> > 500 patches. In this first series there are only 118 of these.
> >> 
> >> Lars,
> >> 
> >> I've only taken a quick glance, but is drbd functional between applying
> >> each patch?
> >> 
> >> It doesn't look like it to me, but I didn't look that close.  I also saw
> >> at least one patch that introduced a new function with no caller to
> >> test it.
> >> 
> >> The idea is that a patch series leave a testable / functional kernel
> >> after each patch in the series is applied sequentially.
> >> 
> >> That is the only way git bisect can do its job.
> >> 
> >> ie. Introducing a new function but no new caller makes a change, but
> >> there is no way to test it.  Therefore there is no real value in not
> >> merging that patch with one that has the new call in it.
> > 
> > Greg,
> > 
> > You replied to mail 000. Please point out to which patch/function you
> > refer, so that we can fix this.
> > 
> > Best,
> >  Phil
> 
> Phillip,
> 
> Take a look at patch 115 of 118 in your series.  I did not review the
> whole series, I just poked around briefly and noticed this one.
> 
> Greg

Ok, I merged 115 into 117, that gives a new 116: